Re: Reopen logfile on SIGHUP

From: Alexander Kuzmenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, andres(at)anarazel(dot)de, stark(at)mit(dot)edu, a(dot)lubennikova(at)postgrespro(dot)ru, pgsql-hackers(at)postgresql(dot)org, g(dot)smolkin(at)postgrespro(dot)ru
Subject: Re: Reopen logfile on SIGHUP
Date: 2018-04-25 14:45:45
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 04/24/2018 06:09 AM, Kyotaro HORIGUCHI wrote:
> It seems that the additional description needs to be meld into
> this at the first place? And some caveat may be needed on failure
> cases.

That's right. I applied your diff and rewrote these paragraphs, adding
some words about the possible loss of messages and how to fix it. I also
removed the forgotten declaration of CheckLogrotateSignal from xlog.h.
The updated patch is attached.

We should probably have a commitfest entry for this, so here it is:

Alexander Kuzmenkov
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
pg_ctl_logrotate_v3.patch text/x-patch 0 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2018-04-25 14:55:54 Re: unused_oids script is broken with bsd sed
Previous Message Christophe Pettus 2018-04-25 14:43:31 Re: Built-in connection pooling