From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgsql: Improve logging of TAP tests. |
Date: | 2015-09-08 21:19:52 |
Message-ID: | 55EF50F8.8040307@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 09/08/2015 02:58 PM, Stephen Frost wrote:
> * Andrew Dunstan (andrew(at)dunslane(dot)net) wrote:
>> Improve logging of TAP tests.
> [...]
>
> This broke 'make check' for REL9_4_STABLE with --enable-tap-tests
> because it added a reference to 'with_temp_install' but didn't actually
> define it.
>
> The attached seems to fix it.
>
> Would be great to get feedback on it as I'm no Makefile expert (it took
> me far too long to run down what was happening and work out what seemed
> like the right fix..).
>
Seems OK to me from a quick look - I guess the proof of the pudding is
in the eating. Does every "make check" target that was working still
work? I assume so. It's interesting that nobody has noticed this for
about 6 weeks.
Our Makefiles do seem to have become fairly esoteric.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2015-09-08 21:31:33 | Re: pgsql: Improve logging of TAP tests. |
Previous Message | Stephen Frost | 2015-09-08 21:03:17 | pgsql: Lock all relations referred to in updatable views |
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2015-09-08 21:22:54 | Re: Allow replication roles to use file access functions |
Previous Message | Kevin Grittner | 2015-09-08 21:13:43 | Re: Getting total and free disk space from paths in PGDATA |