Re: pgsql: Improve logging of TAP tests.

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgsql: Improve logging of TAP tests.
Date: 2015-09-08 21:31:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

* Andrew Dunstan (andrew(at)dunslane(dot)net) wrote:
> On 09/08/2015 02:58 PM, Stephen Frost wrote:
> >Would be great to get feedback on it as I'm no Makefile expert (it took
> >me far too long to run down what was happening and work out what seemed
> >like the right fix..).
> Seems OK to me from a quick look - I guess the proof of the pudding
> is in the eating. Does every "make check" target that was working
> still work? I assume so. It's interesting that nobody has noticed
> this for about 6 weeks.

This only impacted individuals running the TAP tests on REL9_4_STABLE
using 'make check', which I'm guessing is a pretty small set (possibly
a set of 1).

make check-world works for me with this patch, I'm guessing that covers
all of the 'make check' cases which use the TAP tests, but even if it
doesn't, it's probably more than enough to be representative.

I'm doing one final run with the latest changes to REL9_4_STABLE and
once those complete, assuming all still looks good, I'll go ahead and
push this.



In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2015-09-08 21:38:45 pgsql: Add temp-check, with_temp_install definition - 9.4
Previous Message Andrew Dunstan 2015-09-08 21:19:52 Re: pgsql: Improve logging of TAP tests.

Browse pgsql-hackers by date

  From Date Subject
Next Message Anastasia Lubennikova 2015-09-08 21:35:50 Re: [PATCH] Microvacuum for gist.
Previous Message Stephen Frost 2015-09-08 21:22:54 Re: Allow replication roles to use file access functions