Re: jsonb_concat: make sure we always return a non-scalar value

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Oskari Saarenmaa <os(at)ohmu(dot)fi>, pgsql-hackers(at)postgresql(dot)org
Cc: Дмитрий Долгов <9erthalion6(at)gmail(dot)com>
Subject: Re: jsonb_concat: make sure we always return a non-scalar value
Date: 2015-09-08 13:54:37
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 09/05/2015 02:47 AM, Oskari Saarenmaa wrote:
> There was a long thread about concatenating jsonb objects to each
> other, but that discussion didn't touch concatenating other types.
> Currently jsonb_concat always just returns the other argument if one
> of arguments is considered empty. This causes surprising behavior
> when concatenating scalar values to empty arrays:
> os=# select '[]'::jsonb || '1'::jsonb;
> 1
> os=# select '[]'::jsonb || '[1]'::jsonb;
> [1]
> os=# select '[]'::jsonb || '1'::jsonb || '2'::jsonb;
> [1, 2]
> os=# select '0'::jsonb || '1'::jsonb;
> [0, 1]
> os=# select '{"x": "y"}'::jsonb || '[1]'::jsonb;
> [{"x": "y"}, 1]
> os=# select '{"x": "y"}'::jsonb || '1'::jsonb;
> ERROR: invalid concatenation of jsonb objects
> Attached a patch to fix and test this. Also added a test case for
> concatenating two scalar values which currently produces an array..
> I'm not sure that behavior makes sense, but didn't want to change that
> in this patch as I guess someone could consider that feature useful.

This looks correct. Barring objection I'll apply this shortly.



In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-09-08 14:13:15 Re: New functions
Previous Message Nathan Wagner 2015-09-08 13:44:02 patch for geqo tweaks