Re: New functions

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Дмитрий Воронин <carriingfate92(at)yandex(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New functions
Date: 2015-09-08 14:13:15
Message-ID: 20150908141315.GC2912@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Michael Paquier wrote:
> On Tue, Sep 8, 2015 at 9:32 AM, Alvaro Herrera wrote:
> > Michael Paquier wrote:
> > I made a couple extra cleanups to the patch, namely: do not call
> > CreateTemplateTupleDesc() just to discard the resulting tupdesc with a
> > subsequent get_call_result_type(); and do not write a \0 to the
> > BIO_s_mem, and instead use BIO_get_mem_data's return value as length
> > when converting str to text *.
> Thanks!
> > FWIW I now think I made a mistake with the error checks that I
> > backpatched, because the wording of the error messages I used "failed to
> > foo" is frowned upon by our message style guidelines. Should be "could
> > not do foo" instead.
> Well... Feel free to use that if it makes you gain two minutes.

Thanks. I changed the ones for BIO_free() too and pushed.

Those comments /* done if we're done */ look a bit redundant to me. I
considered just removing it altogether ...

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2015-09-08 14:39:05 Re: checkpointer continuous flushing
Previous Message Andrew Dunstan 2015-09-08 13:54:37 Re: jsonb_concat: make sure we always return a non-scalar value