Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Date: 2015-07-20 07:47:31
Message-ID: 55ACA793.7080400@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 07/18/2015 04:15 PM, Alvaro Herrera wrote:
> Heikki Linnakangas wrote:
>> If it's there just to so you can run the regression tests that come
>> with it, it might make sense to just add a "default" case to that
>> switch to handle any unrecognized commands, and perhaps even remove
>> the cases for the currently untested subcommands as it's just dead
>> code.
>
> Well, I would prefer to have an output that says "unrecognized" and then
> add more test cases to the SQL files so that there's not so much dead
> code. I prefer that to removing the C support code, because then as
> we add extra tests we don't need to modify the C source.

Ok. I added a case for AT_ReAddComment, and also a default-case that
says "unrecognized".
- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2015-07-20 08:05:19 Re: Support for N synchronous standby servers - take 2
Previous Message Marti Raudsepp 2015-07-20 07:31:11 Re: [PATCH] pg_upgrade fails when postgres/template1 isn't in default tablespace

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2015-07-20 08:41:46 Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Previous Message Heikki Linnakangas 2015-07-20 07:45:47 pgsql: Handle AT_ReAddComment in test_ddl_deparse, and add a catch-all