| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY |
| Date: | 2015-07-20 08:41:46 |
| Message-ID: | 20150720084146.GF2301@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Heikki Linnakangas wrote:
> On 07/18/2015 04:15 PM, Alvaro Herrera wrote:
> >Heikki Linnakangas wrote:
> >>If it's there just to so you can run the regression tests that come
> >>with it, it might make sense to just add a "default" case to that
> >>switch to handle any unrecognized commands, and perhaps even remove
> >>the cases for the currently untested subcommands as it's just dead
> >>code.
> >
> >Well, I would prefer to have an output that says "unrecognized" and then
> >add more test cases to the SQL files so that there's not so much dead
> >code. I prefer that to removing the C support code, because then as
> >we add extra tests we don't need to modify the C source.
>
> Ok. I added a case for AT_ReAddComment, and also a default-case that says
> "unrecognized".
Oh, sorry, I forgot to tell you that I was working on it.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-07-20 09:21:26 | pgsql: Add some comments to test_ddl_deparse and a README |
| Previous Message | Heikki Linnakangas | 2015-07-20 07:47:31 | Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-07-20 09:07:29 | Re: Implementation of global temporary tables? |
| Previous Message | Heikki Linnakangas | 2015-07-20 08:14:05 | All-zero page in GIN index causes assertion failure |