| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Partitioned tables and relfilenode |
| Date: | 2017-03-06 07:56:46 |
| Message-ID: | 559eb47d-6eca-42b2-7527-c1b034d1597d@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/03/06 16:49, Ashutosh Bapat wrote:
> On Mon, Mar 6, 2017 at 12:48 PM, Amit Langote wrote:
>> On 2017/03/06 15:41, Michael Paquier wrote:
>>> This comment is not completely correct. Children can be temp tables,
>>> they just cannot be temp tables of other backends. It seems to me that
>>> you could still keep this code simple and remove has_child..
>>
>> I updated the comment. I recall having posted a patch for that once, but
>> perhaps went unnoticed.
>
> The existing comment only specifies "temp tables" and not "temp table
> of other backends". The new comment keeps that part same and adds
> partitioned table case. So, I don't see any reason to change the "temp
> tables" to "temp table of other backends" in this patch.
Hmm. A separate patch might be fine but why not fix the incorrect part
while we are updating the whole comment anyway.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2017-03-06 07:59:03 | Re: Foreign Join pushdowns not working properly for outer joins |
| Previous Message | Ashutosh Bapat | 2017-03-06 07:49:37 | Re: Partitioned tables and relfilenode |