| From: | David Steele <david(at)pgbackrest(dot)org> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Andy Pogrebnoi <andrew(dot)pogrebnoi(at)percona(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Haibo Yan <tristan(dot)yim(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Shaun Thomas <shaun(dot)thomas(at)pgedge(dot)com> |
| Subject: | Re: Return pg_control from pg_backup_stop(). |
| Date: | 2026-09-28 06:03:21 |
| Message-ID: | 556bef11-938d-45ca-94b3-7143a3cb532d@pgbackrest.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Shihao,
On 9/27/26 19:13, shihao zhong wrote:
>
> On the pg_resetwal patch, one question before I write it. A restored backup
> is never cleanly shut down, so pg_resetwal already needs -f there. A
> backup_label check that -f overrides would only change the message. I'd
> rather refuse even with -f, like the postmaster.pid check, and make the user
> remove backup_label by hand. 058 would then need to remove backup_label
> before its pg_resetwal step.
I would definitely prefer to force the user to remove backup_label
before pg_resetwal will continue (even with -f). The presence of
backup_label indicates they are making a mistake by using pg_resetwal,
when they should probably be configuring recovery instead.
Regards,
-David
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Peter Smith | 2026-09-28 05:41:22 | Re: Support EXCEPT for ALL SEQUENCES publications |