Re: Return pg_control from pg_backup_stop().

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: David Steele <david(at)pgbackrest(dot)org>
Cc: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Andy Pogrebnoi <andrew(dot)pogrebnoi(at)percona(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Haibo Yan <tristan(dot)yim(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Shaun Thomas <shaun(dot)thomas(at)pgedge(dot)com>
Subject: Re: Return pg_control from pg_backup_stop().
Date: 2026-09-27 16:13:11
Message-ID: CAGRkXqRziLU_gQNM6J39n_ce0OE1EBg1=DvwXyZoRK-fYxhqSg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi David,

On the pg_resetwal patch, one question before I write it. A restored backup
is never cleanly shut down, so pg_resetwal already needs -f there. A
backup_label check that -f overrides would only change the message. I'd
rather refuse even with -f, like the postmaster.pid check, and make the user
remove backup_label by hand. 058 would then need to remove backup_label
before its pg_resetwal step. Does that work for you? Or you would prefer
to have a warning message only.

Thanks,
Shihao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-09-27 16:18:40 Re: [PATCH] Refactor remaining zero-fill relation extensions to use smgrzeroextend()
Previous Message shihao zhong 2026-09-27 16:02:56 Re: Return pg_control from pg_backup_stop().