Re: [sqlsmith] Failed assertion in numeric aggregate

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andreas Seltenreich <seltenreich(at)gmx(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [sqlsmith] Failed assertion in numeric aggregate
Date: 2016-09-04 12:12:31
Message-ID: 555a337d-2911-244b-3ec2-beb80ed33541@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09/03/2016 08:59 PM, Tom Lane wrote:
> Andreas Seltenreich <seltenreich(at)gmx(dot)de> writes:
>> Digging in the coredumps, it looks like set_var_from_num() is invoked on
>> an uninitialized NumericVar. Sample gdb session below.
>
> Hm, yeah, looks like numeric_poly_deserialize is missing a required
> init_var() step. Slightly astonishing that this got through even
> minimal testing.
>
> For the archives' sake: I could not reproduce this at default settings,
> because the aggregate calls don't get parallelized. But it fails fairly
> quickly with
> set parallel_tuple_cost = 0;
> set parallel_setup_cost = 0;
> set min_parallel_relation_size = 0;
>
> Thanks for the report!

Thanks for fixing this so quickly. For the record, I did test
parallelization at one point, but maybe it was with an older patch
version or I screwed up something in the tests - otherwise I clearly
would've hit that.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Abhijit Menon-Sen 2016-09-04 13:32:17 Re: LSN as a recovery target
Previous Message Christoph Berg 2016-09-04 11:46:03 Re: pg_hba_file_settings view patch