Re: pgsql: Make hstore_plperl's build even more like plperl's

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make hstore_plperl's build even more like plperl's
Date: 2015-05-02 12:05:30
Message-ID: 5544BD8A.5050802@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 5/2/15 4:32 AM, Andrew Dunstan wrote:
>
>
>
>
> On 05/01/2015 10:20 PM, Peter Eisentraut wrote:
>> Make hstore_plperl's build even more like plperl's
>>
>> Combine the two places that set CPPFLAGS into one. Also, some settings
>> should be restricted to Windows only. More precisely, -Wno-comment is
>> a GCC-only option, but Windows in a makefile implies GCC at the moment.
>>
>> Also, since -Wno-comment is more properly a preprocessor option, move it
>> to CPPFLAGS to simplify things a bit.
>>
>
> Did you actually test this? On my system you have just managed to break
> what I had unbroken.

I have re-fixed my fix.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2015-05-02 14:20:56 Re: pgsql: Make hstore_plperl's build even more like plperl's
Previous Message Peter Eisentraut 2015-05-02 12:04:51 pgsql: hstore_plperl: Move port-specific parts to later in the makefile