Re: pgsql: Make hstore_plperl's build even more like plperl's

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make hstore_plperl's build even more like plperl's
Date: 2015-05-02 08:32:43
Message-ID: 55448BAB.1000702@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 05/01/2015 10:20 PM, Peter Eisentraut wrote:
> Make hstore_plperl's build even more like plperl's
>
> Combine the two places that set CPPFLAGS into one. Also, some settings
> should be restricted to Windows only. More precisely, -Wno-comment is
> a GCC-only option, but Windows in a makefile implies GCC at the moment.
>
> Also, since -Wno-comment is more properly a preprocessor option, move it
> to CPPFLAGS to simplify things a bit.
>

Did you actually test this? On my system you have just managed to break
what I had unbroken. I'm not pleased.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2015-05-02 12:04:51 pgsql: hstore_plperl: Move port-specific parts to later in the makefile
Previous Message Peter Eisentraut 2015-05-02 03:16:00 Re: pgsql: Move interpreter shared library detection to configure