From: | Jürgen Strobel <juergen+postgresql(at)strobel(dot)info> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation |
Date: | 2018-11-09 21:34:37 |
Message-ID: | 553783fa-c48f-629a-daa9-602599deb516@strobel.info |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On 2018-11-09 22:11, Alvaro Herrera wrote:
> On 2018-Nov-09, Jürgen Strobel wrote:
>
>> I am slightly confused now, I thought this landmine was already fixed in
>> master and what remains is only whether to backport it or not? Which I
>> guess depends on whether this is classified as a bug or not.
>
> Hmm, I changed (and back-patched) what happens to the NOT NULL clauses,
> but as I understand the behavior of the DEFAULT clauses has not changed.
>
>> Since the fix has the potential to break current applications and the
>> documentation is vague about wanted behavior I think it would be
>> sensible to add a warning only, even if we agree to call it a bug.
>
> Hmm, the part I was first proposing to backpatch as an ERROR was a
> mismatch in the COLLATE clause; then I talked about using a WARNING. I
> ended up backpatching neither -- only immortalized the current behavior
> in a test case. I think it should be an ERROR, but in master only.
>
>
> The DEFAULT clauses are a different problem (landmine) :-)
>
OK got it. I agree about differing COLLATE clauses making no sense and
with the ERROR+WARNING solution, but I didn't report that.
The NULL violation is obvious too.
I still hope for a bug fix for the DEFAULT clause with sensible
restrictions.
-Jürgen
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2018-11-09 21:42:28 | Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation |
Previous Message | Alvaro Herrera | 2018-11-09 21:11:06 | Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2018-11-09 21:42:28 | Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation |
Previous Message | James Coleman | 2018-11-09 21:32:23 | Convert MAX_SAOP_ARRAY_SIZE to new guc |