Re: Auditing extension for PostgreSQL (Take 2)

From: David Steele <david(at)pgmasters(dot)net>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Subject: Re: Auditing extension for PostgreSQL (Take 2)
Date: 2015-04-14 15:02:50
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Attached is the v7 pg_audit patch.

I've tried to address Peter's documentation concerns by cleaning up the
terminology and adding a real-world case plus usage recommendations.
The word "auditing" has been expunged from the docs in favor of the term
"audit logging".

Per Simon's request, there is now a pg_audit.log_relation setting that
makes session audit logging exhaustively log all relations as it did
before. The ROLE logging class is back as well.

Simon also suggested a way that pg_audit could be tested with standard
regression so I have converted all tests over and removed

Sawada, I'd certainly appreciate it if you'd try again and see if you
are still getting a segfault with your test code (which you can find in
the regression tests).

Currently the patch will compile on master (I tested with b22a36a) or
optionally with Alvaro's deparse patches applied (only 0001 & 0002
needed). I've supplied a different regression test out file
(expected/pg_audit-deparse.out) which can be copied over the standard
out file (expected/pg_audit.out) if you'd like to do regression on
pg_audit with deparse. The small section of code that calls
pg_event_trigger_ddl_commands() can be compiled by defining DEPARSE or
removed the #ifdefs around that block.

Please let me know if I've missed anything and I look forward to
comments and questions.

- David Steele

Attachment Content-Type Size
pg_audit-v7.patch text/plain 127.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2015-04-14 15:15:27 Re: FPW compression leaks information
Previous Message Magnus Hagander 2015-04-14 15:00:18 Re: FPW compression leaks information