From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | david(at)pgmasters(dot)net |
Cc: | simon(at)2ndQuadrant(dot)com, pgsql-hackers(at)postgresql(dot)org, sawada(dot)mshk(at)gmail(dot)com, peter_e(at)gmx(dot)net, alvherre(at)2ndquadrant(dot)com, ams(at)2ndQuadrant(dot)com, masao(dot)fujii(at)gmail(dot)com |
Subject: | Re: Auditing extension for PostgreSQL (Take 2) |
Date: | 2015-04-14 23:13:54 |
Message-ID: | 20150415.081354.1167351714960358354.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
This patch does not apply cleanly due to the moving of pgbench (patch
to filelist.sgml failed).
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
> Attached is the v7 pg_audit patch.
>
> I've tried to address Peter's documentation concerns by cleaning up the
> terminology and adding a real-world case plus usage recommendations.
> The word "auditing" has been expunged from the docs in favor of the term
> "audit logging".
>
> Per Simon's request, there is now a pg_audit.log_relation setting that
> makes session audit logging exhaustively log all relations as it did
> before. The ROLE logging class is back as well.
>
> Simon also suggested a way that pg_audit could be tested with standard
> regression so I have converted all tests over and removed test.pl.
>
> Sawada, I'd certainly appreciate it if you'd try again and see if you
> are still getting a segfault with your test code (which you can find in
> the regression tests).
>
> Currently the patch will compile on master (I tested with b22a36a) or
> optionally with Alvaro's deparse patches applied (only 0001 & 0002
> needed). I've supplied a different regression test out file
> (expected/pg_audit-deparse.out) which can be copied over the standard
> out file (expected/pg_audit.out) if you'd like to do regression on
> pg_audit with deparse. The small section of code that calls
> pg_event_trigger_ddl_commands() can be compiled by defining DEPARSE or
> removed the #ifdefs around that block.
>
> Please let me know if I've missed anything and I look forward to
> comments and questions.
>
> Thanks,
> --
> - David Steele
> david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2015-04-14 23:57:13 | Re: Auditing extension for PostgreSQL (Take 2) |
Previous Message | David Steele | 2015-04-14 23:12:41 | Re: Turning off HOT/Cleanup sometimes |