Re: What exactly is our CRC algorithm?

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: What exactly is our CRC algorithm?
Date: 2015-04-14 14:10:59
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 04/03/2015 05:28 AM, Abhijit Menon-Sen wrote:
> At 2015-04-03 00:33:10 +0300, hlinnaka(at)iki(dot)fi wrote:
>> I came up with the attached.
> I like it very much.
> src/port/Makefile has (note src/srv):
> +# pg_crc32c_sse42.o and its _src.o version need CFLAGS_SSE42
> +pg_crc32c_sse42.o: CFLAGS+=$(CFLAGS_SSE42)
> +pg_crc32c_sse42_srv.o: CFLAGS+=$(CFLAGS_SSE42)
> Other than that, this looks great. Thank you.
>> BTW, we might want to move the "traditional" and "legacy" crc32
>> implementations out of src/common. They are only used in backend
>> code now.
> I agree.

Committed this now, after some further cleanup and reorganizing the
autoconf stuff.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Emre Hasegeli 2015-04-14 14:45:32 Re: BRIN range operator class
Previous Message Heikki Linnakangas 2015-04-14 14:09:28 pgsql: Use Intel SSE 4.2 CRC instructions where available.