Re: What exactly is our CRC algorithm?

From: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: What exactly is our CRC algorithm?
Date: 2015-04-03 02:28:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

At 2015-04-03 00:33:10 +0300, hlinnaka(at)iki(dot)fi wrote:
> I came up with the attached.

I like it very much.

src/port/Makefile has (note src/srv):

+# pg_crc32c_sse42.o and its _src.o version need CFLAGS_SSE42
+pg_crc32c_sse42.o: CFLAGS+=$(CFLAGS_SSE42)
+pg_crc32c_sse42_srv.o: CFLAGS+=$(CFLAGS_SSE42)

Other than that, this looks great. Thank you.

> BTW, we might want to move the "traditional" and "legacy" crc32
> implementations out of src/common. They are only used in backend
> code now.

I agree.

-- Abhijit

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2015-04-03 02:41:39 Re: Abbreviated keys for Numeric
Previous Message Alvaro Herrera 2015-04-03 02:04:55 Re: Table-level log_autovacuum_min_duration