Re: Proposal : REINDEX xxx VERBOSE

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal : REINDEX xxx VERBOSE
Date: 2015-03-13 12:57:44
Message-ID: 5502DEC8.3060904@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/13/15 6:48 AM, Robert Haas wrote:
> On Wed, Mar 11, 2015 at 5:36 PM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> wrote:
>> The thing is, ()s are actually an odd-duck. Very little supports it, and
>> while COPY allows it they're not required. EXPLAIN is a different story,
>> because that's not WITH; we're actually using () *instead of* WITH.
>
> Generally, I think the commands that don't have () are the older ones,
> and those that do have it are the newer ones: EXPLAIN, VERBOSE, the
> newest of our three COPY syntaxes, CREATE MATERIALIZED VIEW, foreign
> data wrappers, servers, and foreign tables. The older stuff like
> CREATE DATABASE and REINDEX that uses ad-hoc syntax instead is a real
> pain in the neck: every time you want to add an option, you've got to
> add new parser rules and keywords, which is bad for the overall
> efficiency of parsing. So I think this argument is exactly backwards:
> parenthesized options are the newer, better way to do this sort of
> thing.

Yeah, that doesn't sound like a good tradeoff compared to making people
type some extra ()s. :(

We should at least support ()s on the other commands though, so that
we're consistent.
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2015-03-13 12:59:10 Re: Parallel Seq Scan
Previous Message Simon Riggs 2015-03-13 12:52:29 Re: Reduce pinning in btree indexes