From: | Michael Meskes <meskes(at)postgresql(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Object files generated by ecpg test suite not ignored on Windows |
Date: | 2015-03-09 17:50:18 |
Message-ID: | 54FDDD5A.50708@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 09.03.2015 16:58, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> The MSVC build creates project directories which contain all the .obj
>> files etc. The file locations for intermediate artefacts are quite
>> different from the way a Unix build works. There is an ignore rule for
>> these directories, which covers the .obj files there. But ecpg files are
>> generated like in Unix builds.
>
> Ah. That's lots more plausible than "no one's ever done any development
> on Windows". I can believe that not so many people have run the ecpg
> tests there.
Completely agreed.
>> Since we have a global ignore rule for .o
>> files it makes plenty of sense to have one for .obj files also.
>> Certainly better than have one rule for each ecpg test case.
>
> Agreed. So we should revert the previous patch ...
Done.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2015-03-09 17:57:28 | Re: Using 128-bit integers for sum, avg and statistics aggregates |
Previous Message | David Fetter | 2015-03-09 17:39:50 | Re: Using 128-bit integers for sum, avg and statistics aggregates |