From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Object files generated by ecpg test suite not ignored on Windows |
Date: | 2015-03-09 15:58:27 |
Message-ID: | 20210.1425916707@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 03/09/2015 11:31 AM, Michael Meskes wrote:
>> I don't have a Windows system to test on, but how come these files were
>> only created in the ecpg testsuite? With the global .gitignore not
>> mentioning *.obj it appears those files are not created anywhere else.
>> Is the build process different for the rest of the tree?
> The MSVC build creates project directories which contain all the .obj
> files etc. The file locations for intermediate artefacts are quite
> different from the way a Unix build works. There is an ignore rule for
> these directories, which covers the .obj files there. But ecpg files are
> generated like in Unix builds.
Ah. That's lots more plausible than "no one's ever done any development
on Windows". I can believe that not so many people have run the ecpg
tests there.
> Since we have a global ignore rule for .o
> files it makes plenty of sense to have one for .obj files also.
> Certainly better than have one rule for each ecpg test case.
Agreed. So we should revert the previous patch ...
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-03-09 16:11:31 | Re: Rethinking the parameter access hooks for plpgsql's benefit |
Previous Message | Robert Haas | 2015-03-09 15:51:48 | Re: Bootstrap DATA is a pita |