Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script
Date: 2015-02-15 17:02:44
Message-ID: 54E0D134.8030605@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2/11/15 10:06 PM, Bruce Momjian wrote:
> pg_upgrade: quote directory names in delete_old_cluster script
>
> This allows the delete script to properly function when special
> characters appear in directory paths, e.g. spaces.

Wouldn't single quotes be better than double quotes if you want to
defend against special characters?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2015-02-15 22:08:48 pgsql: Minor housekeeping on JSON docs.
Previous Message Peter Eisentraut 2015-02-15 07:48:04 pgsql: pg_regress: Write processed input/*.source into output dir

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2015-02-15 17:10:47 Re: mogrify and indent features for jsonb
Previous Message Andres Freund 2015-02-15 17:00:14 NOT NULL markings for BKI columns