| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script |
| Date: | 2015-02-16 21:44:35 |
| Message-ID: | 20150216214435.GC24298@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Feb 15, 2015 at 12:02:44PM -0500, Peter Eisentraut wrote:
> On 2/11/15 10:06 PM, Bruce Momjian wrote:
> > pg_upgrade: quote directory names in delete_old_cluster script
> >
> > This allows the delete script to properly function when special
> > characters appear in directory paths, e.g. spaces.
>
> Wouldn't single quotes be better than double quotes if you want to
> defend against special characters?
I thought of that. Windows only does double-quotes, I think, and I
didn't see any value to doing a platform-specific quoting. Do you?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2015-02-16 21:47:23 | Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script |
| Previous Message | Kevin Grittner | 2015-02-16 21:29:23 | pgsql: Eliminate unnecessary NULL checks in picksplit method of intarra |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2015-02-16 21:47:23 | Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script |
| Previous Message | Bruce Momjian | 2015-02-16 21:35:46 | Re: Allow "snapshot too old" error, to prevent bloat |