Re: _pg_relbuf() Relation paramter

On 02/04/2015 04:49 PM, Kevin Grittner wrote:
> I ran across this function in nbtpage.c:
>
> /*
> * _bt_relbuf() -- release a locked buffer.
> *
> * Lock and pin (refcount) are both dropped.
> */
> void
> _bt_relbuf(Relation rel, Buffer buf)
> {
> UnlockReleaseBuffer(buf);
> }
>
> Would anyone object to me removing the first parameter (including,
> obviously, in all references in our code tree)?

No objection, although I have to wonder why bother? While you're at it,
the 'size' argument to _bt_pageinit is also pretty useless. It's useless
for PageInit() too, but that's used in more places, potentially even in
extensions. (there's a call to _bt_relbuf in contrib/pgstattuple, but it
shouldn't really be used in 3rd party extensions)

- Heikki