Re: Build broken since 9aaa062 because of missing isnan and isinf

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Build broken since 9aaa062 because of missing isnan and isinf
Date: 2015-01-29 12:53:56
Message-ID: 54CA2D64.2070908@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

On 01/29/2015 01:51 PM, Michael Paquier wrote:
> On Thu, Jan 29, 2015 at 8:34 PM, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
>> Oh, thanks, fixed. I vaguely remembered that Windows doesn't have those
>> macros, but it actually worked on my Windows system. Maybe they've added
>> them to the MSVC headers recently...
> Yes, they have been added in MS 2013. I think that my patch is
> actually a bit wrong, we may want to use _MSC_VER < 1800 as well.

Good point. I'm seeing a compiler warning on my system now, about
redefining isnan and isinf. I rewrote the #ifdef as:

#if defined(WIN32) && !defined(isnan)

That seems to fix the warnings.

- Heikki

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Tom Lane 2015-01-29 15:29:22 Re: Build broken since 9aaa062 because of missing isnan and isinf
Previous Message Michael Paquier 2015-01-29 12:36:54 Re: Regression tests