| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-odbc(at)postgresql(dot)org> |
| Subject: | Re: Build broken since 9aaa062 because of missing isnan and isinf |
| Date: | 2015-01-29 15:29:22 |
| Message-ID: | 4853.1422545362@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-odbc |
Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> On 01/29/2015 01:51 PM, Michael Paquier wrote:
>> Yes, they have been added in MS 2013. I think that my patch is
>> actually a bit wrong, we may want to use _MSC_VER < 1800 as well.
> Good point. I'm seeing a compiler warning on my system now, about
> redefining isnan and isinf. I rewrote the #ifdef as:
You might want to make it match the existing core coding in port/win32.h:
#if (_MSC_VER < 1800)
#define isinf(x) ((_fpclass(x) == _FPCLASS_PINF) || (_fpclass(x) == _FPCLASS_NINF))
#define isnan(x) _isnan(x)
#endif
That's been through the wars, unlike whatever you just came up with.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sandeep CHAYANAM | 2015-02-02 16:32:34 | PostgreSQL ODBC drivers question |
| Previous Message | Heikki Linnakangas | 2015-01-29 12:53:56 | Re: Build broken since 9aaa062 because of missing isnan and isinf |