| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Using 128-bit integers for sum, avg and statistics aggregates |
| Date: | 2014-11-14 01:41:44 |
| Message-ID: | 54655DD8.5090005@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/14/2014 02:25 AM, Peter Eisentraut wrote:
> There is something odd about your patch. I claims that all files are
> new files, e.g.:
>
> diff --git a/src/backend/utils/adt/numeric.c
> b/src/backend/utils/adt/numeric.c
> new file mode 100644
> index d61af92..98183b4
> *** a/src/backend/utils/adt/numeric.c
> --- b/src/backend/utils/adt/numeric.c
Those lines look fine to me.
It does not say I have added a new file, it only claims I have changed
the mode of the file. And that is an artifact from using the script
src/tools/git-external-diff which always outputs a line with "new file
mode".
--
Andreas Karlsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-11-14 01:48:26 | Re: EXPLAIN ANALYZE output weird for Top-N Sort |
| Previous Message | David G Johnston | 2014-11-14 01:35:35 | Re: EXPLAIN ANALYZE output weird for Top-N Sort |