Re: Using 128-bit integers for sum, avg and statistics aggregates

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Andreas Karlsson <andreas(at)proxel(dot)se>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Using 128-bit integers for sum, avg and statistics aggregates
Date: 2014-11-14 01:25:21
Message-ID: 54655A01.8030204@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/13/14 7:57 PM, Andreas Karlsson wrote:
> On 11/13/2014 03:38 AM, Alvaro Herrera wrote:
>> configure is a generated file. If your patch touches it but not
>> configure.in, there is a problem.
>
> Thanks for pointing it out, I have now fixed it.

There is something odd about your patch. I claims that all files are
new files, e.g.:

diff --git a/src/backend/utils/adt/numeric.c
b/src/backend/utils/adt/numeric.c
new file mode 100644
index d61af92..98183b4
*** a/src/backend/utils/adt/numeric.c
--- b/src/backend/utils/adt/numeric.c

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-11-14 01:31:44 Re: [HACKERS] Re: Performance issue with libpq prepared queries on 9.3 and 9.4
Previous Message Stephen Frost 2014-11-14 01:24:36 Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS