| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | noah(at)leadboat(dot)com, shigeru(dot)hanada(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: inherit support for foreign tables |
| Date: | 2014-10-24 06:15:52 |
| Message-ID: | 5449EE98.1040704@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2014/10/21 17:40), Etsuro Fujita wrote:
> (2014/10/14 20:00), Etsuro Fujita wrote:
>> Here are separated patches.
>>
>> fdw-chk.patch - CHECK constraints on foreign tables
>> fdw-inh.patch - table inheritance with foreign tables
>>
>> The latter has been created on top of [1].
>
>> [1] http://www.postgresql.org/message-id/540DA168.3040407@lab.ntt.co.jp
>
> To be exact, it has been created on top of [1] and fdw-chk.patch.
>
> I noticed that the latter disallows TRUNCATE on inheritance trees that
> contain at least one child foreign table. But I think it would be
> better to allow it, with the semantics that we quietly ignore the child
> foreign tables and apply the operation to the child plain tables, which
> is the same semantics as ALTER COLUMN SET STORAGE on such inheritance
> trees. Comments welcome.
Done. And I've also a bit revised regression tests for both patches.
Patches attached.
Thanks,
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| fdw-chk-2.patch | text/x-diff | 25.1 KB |
| fdw-inh-2.patch | text/x-diff | 87.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2014-10-24 06:26:27 | Re: Getting rid of "accept incoming network connections" prompts on OS X |
| Previous Message | Craig Ringer | 2014-10-24 05:42:19 | Re: [Windows,PATCH] Use faster, higher precision timer API |