Re: json casts

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Hannu Krosing <hannu(at)2ndQuadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: json casts
Date: 2014-05-28 22:48:09
Message-ID: 538667A9.9050901@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 05/27/2014 07:25 PM, Andrew Dunstan wrote:
>
> On 05/27/2014 07:17 PM, Tom Lane wrote:
>> Stephen Frost <sfrost(at)snowman(dot)net> writes:
>>> * Andrew Dunstan (andrew(at)dunslane(dot)net) wrote:
>>>> Given that this would be a hard coded behaviour change, is it too
>>>> late to do this for 9.4?
>>> No, for my 2c.
>> If we do it by adding casts then it'd require an initdb, so I'd vote
>> against that for 9.4. If we just change behavior in json.c then that
>> objection doesn't apply, so I wouldn't complain.
>>
>>
>
>
> I wasn't proposing to add a cast, just to allow users to add one if
> they wanted. But I'm quite happy to go with special-casing timestamps,
> and leave the larger question for another time.
>
>

Here's a draft patch. I'm still checking to see if there are other
places that need to be fixed, but I think this has the main one.

cheers

andrew

Attachment Content-Type Size
jsonts.patch text/x-patch 5.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-05-28 22:51:12 Re: replication protocol documentation inconsistencies
Previous Message Andres Freund 2014-05-28 22:41:56 Re: CREATE REPLICATION SLOT fails on a timeout