Re: CREATE REPLICATION SLOT fails on a timeout

Hi,

On 2014-05-17 01:34:25 +0200, Andres Freund wrote:
> On 2014-05-16 17:02:33 -0400, Steve Singer wrote:
> > >I don't think that's going to cut it though. The creation can take
> > >longer than whatever wal_sender_timeout is set to (when there's lots of
> > >longrunning transactions). I think checking whether last_reply_timestamp
> > >= 0 during timeout checking is more robust.
>
> > That makes sense.
> > A patch that does that is attached.
>
> I've attached a heavily revised version of that patch. Didn't touch all
> the necessary places...
>
> Survives creation of logical replication slots under 'intensive
> pressure', with a wal_sender_timeout=10ms.
>
> Thanks for the bugreport!

Pushed a fix for it. I am pretty sure it will, but could you still test
that it fixes your problem?

Thanks!

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services