Re: popen and pclose redefinitions causing many warning in Windows build

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: popen and pclose redefinitions causing many warning in Windows build
Date: 2014-05-15 13:29:12
Message-ID: 5374C128.2060405@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05/15/2014 04:15 PM, Michael Paquier wrote:
> On Thu, May 15, 2014 at 6:20 PM, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
>> Ok, I committed #undefs. I don't have a Mingw(-w64) environment to test
>> with, so let's see if the buildfarm likes it.
> There does not seem to be a buildfarm machine using MinGW-w64...

Jacana. It has "gcc 4.8.1" listed as the compiler, but if you look at
the config in detail, it's mingw-w64. The popen/pclose warnings are
there. It hasn't performed a build after I committed the fix yet.

> Btw, I tested latest master on a Windows box and MinGW-w64 is happier now.

Thanks!

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Arthur Axel 'fREW' Schmidt 2014-05-15 13:35:20 Re: GSOC13 proposal - extend RETURNING syntax
Previous Message Amit Langote 2014-05-15 13:23:19 Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers