| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Default to hidden visibility for extension libraries where possi |
| Date: | 2022-07-18 02:34:42 |
| Message-ID: | 532024.1658111682@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> I don't know how the configure exec bit got removed, shell history doesn't
> show anything odd in that regard. I do see a mistake in locally merging the
> symbol-visibility branch (leading to a crucial commit being missed). I do see
> in shell history that I ran check-world without a failure just before pushing,
> which should have shown the failure, but didn't.
check-world would not have re-run configure even if it was out of date
(only config.status), so that part of it's not so surprising.
> Definitely a brown paper bag moment.
We've all been there :-)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-07-18 06:06:39 | pgsql: Convert macros to static inline functions (tupmacs.h) |
| Previous Message | Andres Freund | 2022-07-18 02:01:55 | Re: pgsql: Default to hidden visibility for extension libraries where possi |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2022-07-18 02:46:44 | Re: NAMEDATALEN increase because of non-latin languages |
| Previous Message | Andres Freund | 2022-07-18 02:01:55 | Re: pgsql: Default to hidden visibility for extension libraries where possi |