Re: pgsql: Default to hidden visibility for extension libraries where possi

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Date: 2022-07-18 02:01:55
Message-ID: 20220718020155.s2soi3niln2skjwi@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2022-07-17 18:39:35 -0700, Andres Freund wrote:
> On 2022-07-18 01:05:56 +0000, Andres Freund wrote:
> > Default to hidden visibility for extension libraries where possible
>
> Looking at the odd failures, not sure what went wrong.

I don't know how the configure exec bit got removed, shell history doesn't
show anything odd in that regard. I do see a mistake in locally merging the
symbol-visibility branch (leading to a crucial commit being missed). I do see
in shell history that I ran check-world without a failure just before pushing,
which should have shown the failure, but didn't.

Definitely a brown paper bag moment.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-07-18 02:34:42 Re: pgsql: Default to hidden visibility for extension libraries where possi
Previous Message Andres Freund 2022-07-18 01:52:33 pgsql: Mark all symbols exported from extension libraries PGDLLEXPORT.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-18 02:34:42 Re: pgsql: Default to hidden visibility for extension libraries where possi
Previous Message Andres Freund 2022-07-18 01:39:35 Re: pgsql: Default to hidden visibility for extension libraries where possi