Re: install libpq.dll in bin directory on Windows / Cygwin

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: install libpq.dll in bin directory on Windows / Cygwin
Date: 2014-02-01 20:22:45
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 02/01/2014 08:01 AM, Peter Eisentraut wrote:
> On 1/31/14, 12:47 PM, Andrew Dunstan wrote:
>> Hmm, looks like it got dropped. I think my original patch is probably
>> about the the right thing to do, and given that it's already done by
>> the MSVC build it's a bug and should be backported, as Alvaro said in
>> the original discussion.
>> I'll get on that shortly - since the patch was untested I'll need to do
>> a test first.
> I think this change is reasonable to make, but it should be in
> Makefile.shlib, not in libpq/Makefile. Makefile.shlib already knows
> about the difference between a link-time and a run-time dynamic library
> (not to speak of Windows vs. others), so the right change there will
> make it work for libpq, ecpg, and whatever else someone might come up
> with automatically.

In the end I went with the way I had suggested, because that's what the
MSVC system does - it doesn't copy any other DLLs to the bin directory.
So doing that seemed sane for backpatching, to bring the two build
systems into sync.

If you want to propose a better arrangement for the future, to include,
say, ecpg DLLs, and including changes to the MSVC system, we can discuss
that separately.



In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-02-01 20:44:14 Re: [9.3 bug] disk space in pg_xlog increases during archive recovery
Previous Message Tom Lane 2014-02-01 20:19:17 Re: What is happening on buildfarm member crake?