Re: Signing off of patches (was Re: Not ready for 8.3)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Signing off of patches (was Re: Not ready for 8.3)
Date: 2007-05-19 01:59:11
Message-ID: 5226.1179539951@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> In order to make patch review more effective, perhaps we could use some
> tools to help us. How about
> http://www.chipx86.com/blog/?p=222

I kinda think this is emphasizing the wrong end of the process. "Code
everything, then ask for comments" is about as far away from the correct
mindset as one can readily get.

I'd like to see something that emphasizes review and feedback at the
stages of germinal idea, rough functional spec, implementation concept,
etc. Reviewing the actual code is good too, but if that's the first
stage that you ask for help at, you are off in the wrong direction;
particularly so if you're a larval Postgres hacker.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Karl O. Pinc 2007-05-19 02:48:20 Re: COPY into a view; help w. design & patch
Previous Message Alvaro Herrera 2007-05-19 01:45:07 Re: Signing off of patches (was Re: Not ready for 8.3)