| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: dump difference between 9.3 and master after upgrade |
| Date: | 2013-06-24 21:53:47 |
| Message-ID: | 51C8BFEB.3080205@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06/24/2013 03:39 PM, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> We probably do need to preserve attribute numbers across an upgrade,
>> even for foreign tables. I think those could make their way into
>> other places.
> Hm ... this argument would also apply to composite types; do we get it
> right for those?
>
>
Yes we do. It's handled at pg_dump.c starting about line 8936.
It looks like we need to add cases of foreign tables to the block that
starts around line 13117.
We should also have a test of this in the core regression tests so that
doing the wrong thing might be caught by regular upgrade testing.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2013-06-24 22:03:11 | Re: GIN improvements part 1: additional information |
| Previous Message | Pavel Stehule | 2013-06-24 21:44:26 | Re: is it bug? - printing boolean domains in sql/xml function |