Re: [PATCH] Remove useless USE_PGXS support in contrib

On 06/15/2013 02:43 PM, David E. Wheeler wrote:
> On Jun 15, 2013, at 4:12 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>> REGRESS_OPTS = --inputdir=test --outputdir=test \
>> --load-extension=$(EXTENSION)
>> ...
>> override pg_regress_clean_files = test/results/
>> test/regression.diffs test/regression.out tmp_check/ log/
>>
>>
>> That keeps the testing stuff out of the way quite nicely.
> I don't suppose there could be a way for the makefile to notice the --outputdir option and add those files to the clean target itself, could there? Having it hard-coded is slightly annoying. Maybe it could ask pg_regress where to find them?
>

That doesn't sound like a promising line of development to me. Better
would be to provide a PGXS option to specify where tests are based, and
set the clean target accordingly.

Then instead of the above you'd just be able to say something like

MODULETEST = test
REGRESS_OPTS = --load-extension=$(EXTENSION)

Which would be a good deal cleaner.

cheers

andrew