| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically |
| Date: | 2017-01-19 16:53:49 |
| Message-ID: | 5146.1484844829@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> Here is a patch that moves two blocks from builtins.h into separate
> header files. That avoids having to include nodes/pg_list.h and
> utils/sortsupport.h.
Seems like a reasonable solution.
> The remaining inclusion of nodes/nodes.h is for the oidparse() function.
> I think that could be moved out of oid.c and put somewhere near parser/
> or objectaddress.c. But the practical savings from avoiding nodes.h is
> probably near zero, so I haven't done anything about that here.
Agreed, not much value in that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-01-19 16:54:07 | Re: pgsql: Add function to import operating system collations |
| Previous Message | Tom Lane | 2017-01-19 16:41:19 | Re: pgsql: Add function to import operating system collations |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-01-19 16:54:07 | Re: pgsql: Add function to import operating system collations |
| Previous Message | Robert Haas | 2017-01-19 16:53:02 | Re: [HACKERS] SEGFAULT in HEAD with replication |