From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Add function to import operating system collations |
Date: | 2017-01-19 16:41:19 |
Message-ID: | 4700.1484844079@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 1/19/17 7:53 AM, Tom Lane wrote:
>> Hm. I see that the patch randomly changed the way that the collation
>> owner is generated ... looks like it no longer works for mixed-case
>> usernames. Perhaps follow this model instead:
> We could just use the numeric value, like in the attached patch.
WFM. Btw, I noticed that BOOTSTRAP_SUPERUSERID is hard-coded as "10"
in this bit in setup_privileges():
" (SELECT E'=r/\"$POSTGRES_SUPERUSERNAME\"' as acl "
" UNION SELECT unnest(pg_catalog.acldefault("
" CASE WHEN relkind = 'S' THEN 's' ELSE 'r' END::\"char\",10::oid))"
" ) as a) "
Is there a reasonable way to fix that? Maybe do another replace_token
call for it?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-01-19 16:53:49 | Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically |
Previous Message | Stephen Frost | 2017-01-19 16:03:05 | Re: [COMMITTERS] pgsql: Add pg_sequence system catalog |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-01-19 16:47:53 | Re: Too many autovacuum workers spawned during forced auto-vacuum |
Previous Message | Stephen Frost | 2017-01-19 16:03:05 | Re: [COMMITTERS] pgsql: Add pg_sequence system catalog |