Re: pkg-config files for libpq and ecpg

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pkg-config files for libpq and ecpg
Date: 2013-02-01 16:34:58
Message-ID: 510BEEB2.4040905@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/15/13 6:53 PM, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> I'll take another stab at providing pkg-config files for the client-side
>> libraries.
>
> This bit:
>
>> + echo 'Libs.private: $(filter-out $(PKG_CONFIG_REQUIRES_PRIVATE:lib%=-l%),$(filter-out -L..%, $(SHLIB_LINK)))' >>$@
>
> appears to assume that SHLIB_LINK contains nothing except -L and -l
> switches. I don't think I trust that a whole lot --- in fact, it
> looks guaranteed to fail on HPUX because of -print-libgcc-file-name.
> There might be other platform-specific bogosity on other platforms;
> PTHREAD_LIBS seems like a likely source for instance.

Updated patch addressing this concern. Also added comments and
documentation.

Attachment Content-Type Size
pg-pkg-config.patch text/plain 6.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2013-02-01 16:35:39 Re: obsolete code
Previous Message Stephen Frost 2013-02-01 16:31:22 Re: obsolete code