Re: Synchronize with imath upstream

Noah Misch <noah(at)leadboat(dot)com> writes:
> The -Wno-declaration-after-statement approach takes eight lines of code, and
> the filter-out approach takes one. On the other hand, using $(filter-out)
> changes any runs of whitespace to single spaces ("$(filter-out foo,a b c)"
> yields "a b c"). We do risk that with CPPFLAGS and LDFLAGS in a few places.
> I don't want to proliferate that practice, because it changes semantics of
> CFLAGS containing -DFOO="arbitrary text".

I don't particularly buy that argument, because CPPFLAGS is where any -D
switches ought to be put. So we've already exposed ourselves to this
risk, in the unlikely scenario where it's not hypothetical.

regards, tom lane