Re: Synchronize with imath upstream

On Sun, Feb 03, 2019 at 06:01:51AM +0000, Andrew Gierth wrote:
> >>>>> "Noah" == Noah Misch <noah(at)leadboat(dot)com> writes:
>
> Noah> If the compiler supports -Wdeclaration-after-statement, I add
> Noah> -Wno-declaration-after-statement for imath.c.
>
> I found it much simpler to strip out -Wdeclaration-after-statement
> instead:
>
> $(RYU_OBJS): override CFLAGS := $(filter-out -Wdeclaration-after-statement,$(CFLAGS))

The -Wno-declaration-after-statement approach takes eight lines of code, and
the filter-out approach takes one. On the other hand, using $(filter-out)
changes any runs of whitespace to single spaces ("$(filter-out foo,a b c)"
yields "a b c"). We do risk that with CPPFLAGS and LDFLAGS in a few places.
I don't want to proliferate that practice, because it changes semantics of
CFLAGS containing -DFOO="arbitrary text".