| From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Patch proposal: New hooks in the connection path |
| Date: | 2022-07-05 07:17:03 |
| Message-ID: | 50d4514e-cf6a-c706-03e9-89644c2c7ff8@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 7/4/22 3:12 PM, Zhihong Yu wrote:
> Hi,
> + FCET_SPT, /* startup packet timeout */
> + FCET_BSP, /* bad startup packet */
>
> Looking at existing enum type, such as FmgrHookEventType, the part
> after underscore is a word.
> I think it would be good to follow existing practice and make the
> enums more readable.
Fair point.
Attached a new version which makes the enums more readable.
Thanks for the feedback
Regards
--
Bertrand Drouvot
Amazon Web Services:https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-connection_hooks.patch | text/plain | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-07-05 07:22:19 | Re: [PATCH] Completed unaccent dictionary with many missing characters |
| Previous Message | Bharath Rupireddy | 2022-07-05 07:07:23 | Re: Patch proposal: New hooks in the connection path |