Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

From: Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Mark Guertin <markguertin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Date: 2023-04-27 15:34:59
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

> Skipping hidden files in pg_rewind added as well as tests for all three
> utilities and mentions of this in the docs. I'll park this in the next
> commitfest for now.

thanks for the update!

I gave the v2 patch a quick review:
* it applies and builds cleanly
* the new TAP tests pass with the changes and fail without
* in a real world test on macOS, the issue with the .DS_Store files on macOS is no longer showing with the patch and reproducible without
* the documentation changes apply and are understandable. One thing seems to be missing, thus: in protocol-replication.html the change should be mentioned as well:

> Various temporary files and directories created during the operation of the PostgreSQL server, such as any file or directory beginning with pgsql_tmp and temporary relations.

In the attached v3 I propose the following change:

- with <filename>pgsql_tmp</filename> and temporary relations.
+ with <filename>pgsql_tmp</filename>, hidden files and temporary relations.

So beside the documentation detail, +1 from my side.


Attachment Content-Type Size
skip_hidden_files_v3.diff application/octet-stream 6.2 KB

In response to


Browse pgsql-bugs by date

  From Date Subject
Next Message Tobias Bussmann 2023-04-27 15:48:26 Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Previous Message PG Bug reporting form 2023-04-27 14:59:30 BUG #17911: Database or JDBC Driver Provides Incorrect Type