Windows help needed for flex and bison

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Windows help needed for flex and bison
Date: 2012-10-11 13:05:22
Message-ID: 5076C412.6050506@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The flex and bison make rules refactoring I just did broke the Windows
build. I think the fixes should look like the patch below. Could
someone please verify and/or commit that?

diff --git a/src/tools/msvc/pgbison.pl b/src/tools/msvc/pgbison.pl
index d6f2444..15db921 100644
--- a/src/tools/msvc/pgbison.pl
+++ b/src/tools/msvc/pgbison.pl
@@ -42,7 +42,7 @@
local $/ = undef;
$make = <$mf>;
close($mf);
-my $headerflag = ($make =~ /\$\(BISON\)\s+-d/ ? '-d' : '');
+my $headerflag = ($make =~ /^$output: BISONFLAGS\b.*-d/ ? '-d' : '');

system("bison $headerflag $input -o $output");
exit $? >> 8;
diff --git a/src/tools/msvc/pgflex.pl b/src/tools/msvc/pgflex.pl
index 259f218..29dbc8e 100644
--- a/src/tools/msvc/pgflex.pl
+++ b/src/tools/msvc/pgflex.pl
@@ -44,7 +44,7 @@
local $/ = undef;
$make = <$mf>;
close($mf);
-my $flexflags = ($make =~ /^\s*FLEXFLAGS\s*=\s*(\S.*)/m ? $1 : '');
+my $flexflags = ($make =~ /^$output:\s*FLEXFLAGS\s*=\s*(\S.*)/m ? $1 : '');

system("flex $flexflags -o$output $input");
if ($? == 0)

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2012-10-11 13:23:12 Re: embedded list
Previous Message Andres Freund 2012-10-11 11:42:29 Re: [RFC][PATCH] wal decoding, attempt #2 - Design Documents (really attached)