| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <peter(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)postgresql(dot)org> |
| Subject: | Re: embedded list |
| Date: | 2012-10-11 13:23:12 |
| Message-ID: | 20121011132311.GA4997@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera escribió:
> I also included two new functions in that patch, dlisti_push_head and
> dlisti_push_tail. These functions are identical to dlist_push_head and
> dlist_push_tail, except that they do not accept non-circular lists.
> What this means is that callers that find the non-circularity acceptable
> can use the regular version, and will run dlist_init() on demand;
> callers that want the super-tight code can use the other version.
> I didn't bother with a new dlist_is_empty.
Is there any more input on this? At this point I would recommend
committing this patch _without_ these dlisti functions, i.e. we will
only have the functions that check for NULL-initialized dlists. We can
later discuss whether to include them or not (it would be a much smaller
patch and would not affect the existing functionality in any way.)
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2012-10-11 13:27:17 | Re: embedded list |
| Previous Message | Peter Eisentraut | 2012-10-11 13:05:22 | Windows help needed for flex and bison |