Re: Unportable use of uname in pg_upgrade test script

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Unportable use of uname in pg_upgrade test script
Date: 2012-09-29 16:35:40
Message-ID: 5067235C.3000901@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 09/29/2012 12:13 PM, Tom Lane wrote:
> BTW, I tried the pg_upgrade regression tests this morning on my dinosaur
> HPUX box, and it promptly fell over with:
>
> uname: illegal option -- o
> usage: uname [-amnrsvil] [-S nodename]
> make: *** [check] Error 1
>
> This is not terribly surprising, because the -o option is nowhere to be
> seen in the Single Unix Spec definition of uname; which means this is
> likely to fail on other platforms too. I would suggest using -s, or no
> option at all, or finding some other way to identify Windows/MSys.

The trouble with uname -s is that its output is a bit variable. I think
this will work:

testhost=`uname -a | sed 's/.* //'`

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2012-09-29 16:40:04 Re: is JSON really "a type" (Re: data to json enhancements)
Previous Message Tom Lane 2012-09-29 16:13:06 Unportable use of uname in pg_upgrade test script