Re: getting "shell command argument contains a newline or carriage return:" error with pg_dumpall when db name have new line in double quote

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Srinath Reddy <srinath2133(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: getting "shell command argument contains a newline or carriage return:" error with pg_dumpall when db name have new line in double quote
Date: 2026-02-02 14:14:28
Message-ID: 500511.1770041668@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> This is not an objection to this patch, but I don't see why we should
> allow newlines in tablespace names if we're going to restrict them in
> names of roles and databases. Is it only because pg_dumpall happens not
> to dump a comment with the tablespace name on it, like we do for dbs and
> roles? Sounds unprincipled.
> I think keeping these things under the same rules makes the most sense.

Yeah, I was thinking the same.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2026-02-02 14:16:42 Re: refactor architecture-specific popcount code
Previous Message Fujii Masao 2026-02-02 14:11:14 Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect