| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Srinath Reddy <srinath2133(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: getting "shell command argument contains a newline or carriage return:" error with pg_dumpall when db name have new line in double quote |
| Date: | 2026-02-02 10:54:34 |
| Message-ID: | 202602021048.m5lsx277xfuw@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
This is not an objection to this patch, but I don't see why we should
allow newlines in tablespace names if we're going to restrict them in
names of roles and databases. Is it only because pg_dumpall happens not
to dump a comment with the tablespace name on it, like we do for dbs and
roles? Sounds unprincipled.
I think keeping these things under the same rules makes the most sense.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"The problem with the facetime model is not just that it's demoralizing, but
that the people pretending to work interrupt the ones actually working."
-- Paul Graham, http://www.paulgraham.com/opensource.html
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-02-02 11:16:20 | Re: getting "shell command argument contains a newline or carriage return:" error with pg_dumpall when db name have new line in double quote |
| Previous Message | Mihail Nikalayeu | 2026-02-02 10:04:45 | Re: Adding REPACK [concurrently] |